Technical retrospective

 

Chappy.​InstagramFeed

Components

  • InstagramFeedView
  • InstagramFeedPresenter

  • InstagramFeedCoordinator

  • InstagramFeedService

Dependencies

  • user ID
  • clientSource:

    • myprofile/encounters/otherprofile

  • MOXUserLoader

  • FeaturesService
  • SharedUserCache
  • NotificationService
  • VerificationService (new)

Transport Entities

Ownership and layers

{ InstagramFeedService , VerificationService, SharedUserCache, etc }

____________________________________

InstagramFeedCoordinator

__________________^__________________

InstagramFeedPresenter

__________________^__________________

InstagramFeedView

Legend:

          Layer:  ____________________________________
Ownership:  ^

InstagramFeedView

InstagramFeedPresenter

ViewModel computation

InstagramFeedCoordinator

FeedState  computation

Verification Service

ExternalProviderConnector

ExternalProviderConnector

Solved problems

BPDPhotoCollection bug

  • Saves only the last album coming from the SRV
  • Fixed version BPDFixedPhotoCollection
  • IOS-13740 Core team task to fix properly

BPDSharedUserCache additions

Added API:

Not progressive JPEG

Extending scrolling area

Non fatal error tracking (asserts)

Non fatal error tracking (asserts)

HotPanel framework fixed hacked

  • Added experimental mode to HP framework
  • trackChildElements option is ignored (always ON)
  • presenting a VC without tracking screen doesn't change current tracking screen
  • Current tracking screen provider
  • Fixed finding parent tracking element and screen
  • ScrollScreen/ScrollElement work like a charm

SnapshotTests

  • FBSnapshotTestCase
  • FBSnapshotsViewer

self.

  • Layout refactoring
  • Long-lexeme-safe 
  • TDD

SnapshotTests

GalleryViewController

HorizontalPagedLayout

FittingCollectionViewLayout

retrochappy

By borlov

retrochappy

  • 943