Code Reviews at HackSoft
Team Rules
Click me
Try to keep the PR small
Open PR as soon as possible
Separate refactoring PRs
Basic AF
Smoke testing
Is the name of the PR good?
Is the build passing?
Is there enough context?
If it's a new feature, why does it have deletes?
Example 1
Example 2
If it's changing something, should it be backwards compatible?
Example 1
Example 2
If it's changing something, is there a regression somewhere else?
Example 1
Example 2
If it's an addition to an existing feature, does it look like everything else? Why not?
If it's a refactoring, does it break something? Usually needs a lot of clicking.
Style checks. Lowest of priorities.
My common sense is tingling ...
Q&A
Made with Slides.com