Adrienne Tacke PRO
🇵🇭 Software Engineer & Sr. Developer 🥑 @ Cisco • Published Author • LinkedIn Learning Instructor • Twitch Streamer 🕹 Most important: I spend way too much money on desserts and endless hours playing Borderlands
Ideal Code Review Goals
Ideal Code Review Goals
Ideal Code Review Goals
Ideal Code Review Goals
(All of "human-origin" 😅)
What are our goals for code reviews?
How long do we give reviewers to approve pull requests?
Do we require a minimum of two approvers for pull requests? Three?
What happens when we need to deploy an emergency fix?
What code conventions do we follow as a team?
*(This can take multiple conversations and will evolve over time!)
(All of "human-origin" 😅)
From a pull request for the materialize repo
From a pull request for the handsontable repo
Objectivity
Objectivity
From a pull request for the materialize repo
💩
Objectivity
Empathy always
Objectivity
Empathy always
Objectivity
Empathy always
Objectivity
Empathy always
consistency
Thank you DevFest Baton Rouge!
By Adrienne Tacke
🇵🇭 Software Engineer & Sr. Developer 🥑 @ Cisco • Published Author • LinkedIn Learning Instructor • Twitch Streamer 🕹 Most important: I spend way too much money on desserts and endless hours playing Borderlands