Ten Commandments

of

Navigating Code Reviews

Angie Jones

http://angiejones.tech

@techgirl1908

Principal Developer Advocate

Applitools, San Francisco, CA, USA

@techgirl1908

@techgirl1908

I.

@techgirl1908

@techgirl1908

II.

@techgirl1908

This is complex for no good reason. 
You don't have to show off. 
Less is more.
This is not me showing off. It's a complex problem and thus warrants a complex solution.
You can accomplish this same thing with a single while loop.
My solution works just as well. You know I really worked hard on this 😔

@techgirl1908

III.

@techgirl1908

You can accomplish this same thing with a single while loop.
Good point. That would be cleaner and remove some of the complexity. 
Let me rework this.

@techgirl1908

IV.

@techgirl1908

You can accomplish this same thing with a single while loop.
Yeah, I initially thought the same thing, but I have to also iterate through the list. That led me to this solution which handles all cases.

@techgirl1908

V.

@techgirl1908

You can accomplish this same thing with a single while loop.
Yeah, I initially thought the same thing, but I have to also iterate through the list. That led me to this solution which handles all cases.
Well, there has to be a simpler approach than this!
I'm all for the simplest approach possible. Let me find some time on your calendar so that we can whiteboard it out.

@techgirl1908

VI.

@techgirl1908

VII.

@techgirl1908

VIII.

@techgirl1908

Why didn't you just make the function's argument optional and set it to a default value?
Oh wow, that's pretty cool! We don't have that option in Java. 
I'll make this change and read a bit more about it as well.

@techgirl1908

IX.

@techgirl1908

X.

Code on!

Angie Jones

http://angiejones.tech

@techgirl1908

Principal Developer Advocate

Applitools, San Francisco, CA, USA