advanced code reviews

Maybe don't take boardgames so seriously.

Code reviews... right...

Why do we do them?

Quality

Learning
mentoring

quality...

How do we protect the code base?

Test the code

Errors in the code
missing tests
tests that don't test things

Code Style errors

ineffecient code patterns*

bad variable names*

confusing abstractionS*

Learning & mentoring

egoless reviews

Apollo 12 and John Aaron

It's easy to react

Why would anyone do that?!

vs.

why would anyone do that?

So what does this look like?

Remember...

We are all learning

fin.

Made with Slides.com