eCommerce AEM Code Quality

Agenda

 
  • Sonar
  • TDD
  • JUnit
  • Crucible
  • Next Steps
 

Coverage

Issues

 

Issues

 

Duplicated Code

 

Lines of Code

 

Comparing with...

 

TDD

 

Test Driven Development

  • TDD is about writing the test first BEFORE adding new functionality to the system. This seems backwards as first, but doing this:

    • Defines success up front.
    • Helps break our design down into LITTLE PIECES, and
    • Leaves us with a nice suite of unit tests PROVING our stuff works.

Life Cycle

Coverage Goals (Scholastic)

  • 80% Healthy
  • ~30% Kids
  • 5.3% eCommerce at Aug 4, 2016

Starting point...

  • There is a new JENKINS JOB configured for running every day at 5:00 AM for generating the reports.
  • We should start writing Unit tests for CURRENT code
  • Then... DESIGNING tests first then writing code
  • Then... DEVELOPING tests first then writing code
 

Principles

More Info

Unit Testing

LoginTest

LoginTest

 

So...

  • First MAIN/CORE FUNCTIONALITIES
  • Almost one SUCCESS and one FAILURE cases

Workflow

 

Crucible

 

So...

  • Each new PR SHOULD have code review in Crucible.
  • Each code review SHOULD have a reviewer
  • Each review SHOULD be closed before merging

Next Steps

 

So...

Made with Slides.com