DEV: Hey man, i just submitted my
PullRequest, please take a look.
LEAD: No, please just merge it!
DEV: WTH! Really? Why?
LEAD: You're part of my team, and I have to trust on you!
Code review is a systematic examination of software source code, intended to find bugs and to estimate the code quality.
Code review is the part of process where i hate all my teammates.
???
???
???
???
???
???
???
???
← Submit Pull Request
← Code Approved / Merged
Front-end Developer, Truextend
@kenji_lozano
Ruin the day of a developer by adding ridiculous observations about the code that he implemented.
Anonymous Dev.
Force a level of communication and shared knowledge between engineers by looking for another ways to solve the same problem -Anonymous
Wants to ensure that the content is produced free of defects... So someone should approve that!.
Submit code for a code review
The reviewer evaluates the code submitted
The code in question is either approved or rejected
Making any required changes to the code
4. Developer Action
1. Code Review Request
2. Code Review Evaluation
WTH ?
Dude ... WTH ?
Really ? WTH
WAT DA HELL
3. Approval and Feedback
Refactor
← Code Approved / Merged
Keep in mind...
There is no perfect code and the best practices changes over the time.
It allows us to have a better quality of code
Be framework agnostic.
If your teammates needs some explanations about your code you're in a wrong way
So let's take a loot at some symptom the let you know that you process goes in a wrong way
I.E. 50 Comments for 10 Lines of Code
Add all ridiculous observations you can
It's FREE!