How to get your PR approved fast

The PR template

Fill out everything

  • Every section in the PR template is important, and is sometimes a reminder to do something (eg, manually test it, get PM/design approvals, write unit or e2e tests).
  • Everything about the PR, the problem you're solving, and testing that's been done should be explained in this template. You can go and edit it later, but DO NOT ask for reviews until it is completed.

Description of Change

  • Be as verbose as possible. Do not just link a JIRA ticket. This is both for people who are reviewing your code to know at a glance what the issue or new feature is, and what your solution is doing. 
  • This is also useful for you, if you need to come back to this PR long after it's merged. 
  • You can put all kinds of information in this section. Have something specific that you want people to look at? list it here. 
  • Please edit this section later if you change your solution due to comments.

Getting approvals

Code ownership

  • Keap web requires one (1) owning person to approve your changes before you merge.
  • If your team owns the code you are changing (as defined in CODEOWNERS) this can be as simple as getting someone who has github access on your team to approve your code.
  • Any code can be approved by fe-admins. Ask for reviews from an admin in the dedicated PR channel: #keap-web-prs (tag @frontendadmins)
Made with Slides.com