Title Text
Benefits of Good Reviews
- Knowledge
- Discussions
- Homogeny
Problems We Might Have
- Inconsistency
- Impatience
- Purposelessness
"Terms of Service" Review
- scroll
- scroll
- scroll
- accept
What Makes a Good Review?
2 phases
Phase 1: "Light Pass"
- Typos / naming
- 1 test
- Style violations
- Most reviews end here
Phase 2: "Contextual Pass"
- Intent
- Good test coverage
- Use of dependencies
- Readability
- Maintainability
- Adherence to story
"Trust No One"
Assume there are bugs
Providing a Good Environment for Reviews
Encourage Pull Requests
- GitHub has great reviewing tools
- Once place for all CR comments
- CI status for commits
- Potential for bot integration w/ hooks
- Easy merge
- Better visibility of all pending changes
Encourage Pull Requests
Myth: "It's too hard/complex!"
Small Diffs
- Break up story into small tasks
- Request periodic reviews
- PR will auto-update
Keep it moving
- Pair review if needed
- Call out "non-blocking" comments
- Don't take it (or make it) personal
Know that you are not perfect
"It's only one line"
