code Created with Sketch.

Goldilocks and the Three Code Reviews

@vaidehijoshi

🐻 🐻 🐻

πŸ™‹πŸ½

πŸ‘©πŸ½β€πŸ’»

Β πŸ’­

πŸ˜ƒ

😍

πŸ€—

πŸ‘Ž

πŸ’ͺ

😟

πŸ‘©πŸ½β€πŸ’»

Β πŸ’­

πŸ‘

😝

πŸŽ‰

πŸ‘©πŸ½β€πŸ’»

Β πŸ’­

πŸ‘

πŸ‘

πŸ‘

πŸ‘

πŸ‘

πŸ‘

πŸ‘

πŸ‘

πŸ‘

πŸ‘

πŸ‘

πŸ‘

LGTM

LGTM

LGTM

LGTM

LGTM

🚨

πŸ”₯

🚨

πŸ”₯

πŸ”₯

🚨

🚨

🚨

πŸ‘©πŸ½β€πŸš’

πŸ™ˆ

oh no.

we really got this code review thing down!

lol j/k NOPE

we really got this code review thing down!

πŸ€¦πŸ½β€β™€οΈ

Β πŸ’­

There must be a better way of doing code reviews!

...Right?

Code Complete

catching problems at the β€œlowest-value” stage

πŸ‘©πŸ½β€πŸ’»

Β πŸ’­

β€œquality gates”

πŸ€”

πŸ‘€

πŸ‘©πŸ½β€πŸ’»

πŸ”„

πŸ”₯

Β πŸ’­

collective ownership in construction

inspections

πŸ‘©πŸ½β€πŸ’»

Β πŸ’­

defect-detection

not correction

short reviews

πŸ‘©πŸ½β€πŸ’»

Β πŸ’­

Code Complete, 2nd Edition,
Steve McConnell

walk throughs

πŸ‘©πŸ½β€πŸ’»

Β πŸ’­

working meetings

Peer Reviews in Software: A Practical Guide,
Karl E. Wiegers

Who is doing the review?

Energy

How much time are they spending on it?

big commits, large PR's, no context

unequal reviewsΒ 

second-class citizens

πŸ‘Ž

πŸ‘Ž

πŸ‘Ž

What exactly are they saying or doing while reviewing?

Substance

And how?

tons of comments, little conversation

focusing on style/ syntax

ego over empathy

πŸ‘Ž

πŸ‘Ž

πŸ‘Ž

πŸ‘©πŸ½β€πŸ’»

πŸ€·πŸ½β€β™€οΈ

πŸ’πŸ½

1. Β commit hooks

small wins

1. Β commit hooks

2. PR templates

small wins

1. Β commit hooks

2. PR templates

3. screenshots/gifs

small wins

1. Β commit hooks

2. PR templates

3. screenshots/gifs

4. linters

small wins

1. Β commit hooks

2. PR templates

3. screenshots/gifs

5. encapsulation

4. linters

small wins

1. Β commit hooks

2. PR templates

3. screenshots/gifs

5. encapsulation

4. linters

6. specific reviewers

small wins

1. Β review everyone: push for a culture that values vulnerability

2. develop empathy: call out the good stuff, too!

big wins

itπŸ‘erπŸ‘ateπŸ‘

3.Β 

iterate

iterate

start the conversation

🀝

I love code reviews in theory.

In practice, they are only as good as the group that’s responsible for conducting them in the right manner.

bettercode.reviews

✨

thank you!

@vaidehijoshi

http://bit.ly/better-code-reviews

Better Code Reviews

By Vaidehi Joshi

Better Code Reviews

  • 1,076
Loading comments...

More from Vaidehi Joshi