Goldilocks and the Three Code Reviews
@vaidehijoshi
🐻 🐻 🐻
🙋🏽
👩🏽💻
💭
😃
😍
🤗
👎
💪
😟
👩🏽💻
💭
👍
😝
🎉
👩🏽💻
💭
👍
👍
👍
👍
👍
👍
👍
👍
👍
👍
👍
👍
LGTM
LGTM
LGTM
LGTM
LGTM
🚨
🔥
🚨
🔥
🔥
🚨
🚨
🚨
👩🏽🚒
🙈
oh no.
we really got this code review thing down!
lol j/k NOPE
we really got this code review thing down!
🤦🏽♀️
💭
There must be a better way of doing code reviews!
...Right?
Code Complete
catching problems at the “lowest-value” stage
👩🏽💻
💭
“quality gates”
🤔
👀
👩🏽💻
🔄
🔥
💭
collective ownership in construction
inspections
👩🏽💻
💭
defect-detection
not correction
short reviews
👩🏽💻
💭
Code Complete, 2nd Edition,
Steve McConnell
walk throughs
👩🏽💻
💭
working meetings
Peer Reviews in Software: A Practical Guide,
Karl E. Wiegers
Who is doing the review?
Energy
How much time are they spending on it?
big commits, large PR's, no context
unequal reviews
second-class citizens
👎
👎
👎
What exactly are they saying or doing while reviewing?
Substance
And how?
tons of comments, little conversation
focusing on style/ syntax
ego over empathy
👎
👎
👎
👩🏽💻
🤷🏽♀️
💁🏽
1. commit hooks
small wins
1. commit hooks
2. PR templates
small wins
1. commit hooks
2. PR templates
3. screenshots/gifs
small wins
1. commit hooks
2. PR templates
3. screenshots/gifs
4. linters
small wins
1. commit hooks
2. PR templates
3. screenshots/gifs
5. encapsulation
4. linters
small wins
1. commit hooks
2. PR templates
3. screenshots/gifs
5. encapsulation
4. linters
6. specific reviewers
small wins
1. review everyone: push for a culture that values vulnerability
2. develop empathy: call out the good stuff, too!
big wins
it👏er👏ate👏
3.
iterate
iterate
start the conversation
🤝
I love code reviews in theory.
In practice, they are only as good as the group that’s responsible for conducting them in the right manner.
bettercode.reviews
✨
thank you!
@vaidehijoshi
http://bit.ly/better-code-reviews
Better Code Reviews
By Vaidehi Joshi
