code Created with Sketch.

crafting better code reviews

@vaidehijoshi

why do I care so much about code reviews to begin with?

πŸ‘©πŸ½β€πŸ’»

Β πŸ’­

πŸ˜ƒ

😍

πŸ€—

πŸ‘Ž

πŸ’ͺ

😟

πŸ‘©πŸ½β€πŸ’»

Β πŸ’­

πŸ‘

😝

πŸŽ‰

πŸ‘©πŸ½β€πŸ’»

Β πŸ’­

πŸ‘

πŸ‘

πŸ‘

πŸ‘

πŸ‘

πŸ‘

πŸ‘

πŸ‘

πŸ‘

πŸ‘

πŸ‘

πŸ‘

LGTM

LGTM

LGTM

LGTM

LGTM

🚨

πŸ”₯

🚨

πŸ”₯

πŸ”₯

🚨

🚨

🚨

πŸ‘©πŸ½β€πŸš’

πŸ™ˆ

oh no.

we really got this code review thing down!

lol j/k NOPE

we really got this code review thing down!

There must be a better way of doing code reviews!

...Right?

Theory

Practice

Theory

Code Complete

catching problems at the β€œlowest-value” stage

β€œquality gates”

πŸ€”

- multiple πŸ‘€ on code

- πŸ”„ bug fixing

- fewer πŸ”₯ when someone leaves

inspections

defect-detection

not correction

short reviews

Code Complete, 2nd Edition,
Steve McConnell

walk throughs

working meetings

Peer Reviews in Software: A Practical Guide,
Karl E. Wiegers

Practice

Energy

Substance

Who is doing the review?

How much time are they spending on it?

Energy

large commits/PR's, no context

unequal reviews (jr vs. sr)

second-class citizens

What exactly are they saying or doing while reviewing?

And how?

Substance

tons of comments < conversation

style/syntax vs. content/semantics

egotistical, rather than empathetic

πŸ‘©πŸ½β€πŸ’»

commit hooks

PR templates

screenshots/gifs, explanations

linters

assign specific reviewers

small, concise, encapsulated work

small things

πŸ‘©πŸ½β€πŸ’»

develop empathy on your team, review everyone

push for a culture that values vulnerabilityβ€Šβ€”β€Šboth in actions and in words

call out the good stuff

have a conversation

big things

itπŸ‘erπŸ‘ateπŸ‘

iterate

iterate

I love code reviews in theory.

In practice, they are only as good as the group that’s responsible for conducting them in the right manner.

start the conversation

🀝

bettercode.reviews

✨

thank you!

@vaidehijoshi

Crafting Better Code Reviews

By Vaidehi Joshi

Crafting Better Code Reviews

  • 1,029