Code Review Guideline

Ouline

  • Code Review 不是 Code Review
  • Checklist
  • The Good Part
  • Could be better
  • Design Discuss

Code Review 不是 Code Review

Why we need Code Review ? 

Readability a.k.a. ‘Understandability’

Readability a.k.a. ‘Understandability’

因為這個 Project

很可能下一個維護的就是你

Maintainability

Maintainability

因為這個 Project

很可能下一個維護的就是你

Checklist

Checklist Question

  • Am I able to understand the code easily?
  • Is the code written following the coding standards/guidelines?
  • Is the same code duplicated more than twice?
  • Is this function or class too big? If yes, is the function or class having too many responsibilities?

Code Review

By Balicanta Yao

Code Review

  • 91