Code Reviews
ANOTHER PERSON
LOOKS AT THE CODE
YOU WROTE
TO FIND MISTAKES
YOU'VE MADE
SURE THING!
BUT FAILING IS GOOD!
EXAMPLE?
1.26 BILLION
TRANSACTION VOLUME
2400 EMPLOYEES
HE FAILED
5.126 TIMES
ON CREATING
THE CYCLONE
VACCUM CLEANER
THAT FINALLY MADE HIM
$$ RICH $$
TO FAIL MEANS
TO SUCCEED AT THE END...
... BUT ONLY
IF FAILURES
ARE BROUGHT
TO LIGHT
YOU
NEED
A
CODE
REVIEW
CODE REVIEWS
LEAD TO
20 - 75 %
REDUCTION
OF FAILURES
ALLOW
FOR HUGE
LEARNINGS
RESULT IN
BETTER CODE
THUS MAKING
IT MORE FUN
TO DEVELOP
TYPICAL
WEAKNESSES
THAT CAN BE
DETECTED
BY A REVIEWER
VIOLATION OF
CODE CONVENTIONS
BAD
MAINTAINABILITY
UNFAVORABLE
DESIGN
MISSING
TESTS
INEXPRESSIVE
CODE
SECURITY
CONCERNS
THE REVIEWER
SHOULD...
ASK
COMPREHENSION
QUESTIONS
MAKE
SUGGESTIONS
FOR
IMPROVEMENTS
POINT TO
A FAILURE
IF YOU REVIEW
PLEASE PREVENT THE
#1 FAILURE
AND DON'T
BE OFFENDING
AS WE ALL DO
OUR BEST
NEXT UP...
KTHXBYE
- go to bit.ly/T0Qopl
-
click
-
click
-
click and select the
#
from your note
- Insert the name of the person to your left into the Reviewers box
- click
-
open your mails
-
click (at the bottom)
- review (add comments)
- ...
Code Reviews
By Marc Dix
Code Reviews
- 1,271