eCommerce AEM Code Quality

Agenda

• Sonar
• TDD
• JUnit
• Crucible
• Next Steps

Sonar

Sonar Scholastic Server

Coverage

Issues

Issues

Duplicated Code

Lines of Code

Comparing with...

TDD

Test Driven Development

• TDD is about writing the test first BEFORE adding new functionality to the system. This seems backwards as first, but doing this:

  • Defines success up front.
  • Helps break our design down into LITTLE PIECES, and
  • Leaves us with a nice suite of unit tests PROVING our stuff works.

Life Cycle

Coverage Goals (Scholastic)

• 80% Healthy
• ~30% Kids
• 5.3% eCommerce at Aug 4, 2016

Starting point...

• There is a new JENKINS JOB configured for running every day at 5:00 AM for generating the reports.
• We should start writing Unit tests for CURRENT code
• Then... DESIGNING tests first then writing code
• Then... DEVELOPING tests first then writing code

Principles

More Info

Scholastic TDD Confluence

Unit Testing

LoginTest

LoginTest

So...

• First MAIN/CORE FUNCTIONALITIES
• Almost one SUCCESS and one FAILURE cases

Crucible

Crucible Ecommerce Project

Workflow

Crucible

So...

• Each new PR SHOULD have code review in Crucible.
• Each code review SHOULD have a reviewer
• Each review SHOULD be closed before merging

Next Steps

So...

• Let's start creating Unit tests for the current code:
  • https://docs.google.com/a/globant.com/spreadsheets/d/1I5uxk7-W7hsQ_9Vhvxzy_NFxNCoAyPXmADJl-mZZ5W0/edit?usp=sharing
• Let's start using crucible for code review.
  • We can start using cross team code review.
• Keep growing in short steps: Improve continuously
• Javascript in SONAR
• Automation?