Ye Olde Days

(Closed Source proprietary API)

Frustration!

Fix the Problem

• Fork repo on Github
• Set up development environment
• Write a failing test
• Identify a solution that passes the checks and tests
• Update docs if necessary

Setup your Dev Environment

• npm install -g grunt

• git clone https://github.com/petebacondarwin/angular.js

• npm install

• grunt package

• git checkout -b issue-11930

• grunt autotest

Write a failing test

it('should not watch array properties that start with $ or $$', function() {
  createSelect({
    'ng-options': 'value as createLabel(value) for value in array',
    'ng-model': 'selected'
  });
  scope.createLabel = jasmine.createSpy()
                        .andCallFake(function(value) { return value; });
  scope.array = ['a', 'b', 'c'];
  scope.array.$$private = 'do not watch';
  scope.array.$property = 'do not watch';
  scope.selected = 'b';
  scope.$digest();

  expect(scope.createLabel).toHaveBeenCalledWith('a');
  expect(scope.createLabel).toHaveBeenCalledWith('b');
  expect(scope.createLabel).toHaveBeenCalledWith('c');
  expect(scope.createLabel).not.toHaveBeenCalledWith('do not watch');
});

Find a solution

Object.keys(values).forEach(function getWatchable(key) {
  
  if (key.charAt(0) === '$') return;

  var locals = getLocals(values[key], key);
  var selectValue = getTrackByValueFn(values[key], locals);
  watchedArray.push(selectValue);

  // Only need to watch the displayFn if there is a specific label expression
  if (match[2] || match[1]) {
    var label = displayFn(scope, locals);
    watchedArray.push(label);
  }

  // Only need to watch the disableWhenFn if there is a specific disable expression
  if (match[4]) {
    var disableWhen = disableWhenFn(scope, locals);
    watchedArray.push(disableWhen);
  }
});

Run all the tests and checks

  grunt test

This is equivalent to

  grunt ci-checks
  grunt package
  grunt test:unit
  grunt test:e2e

Submit the fix

• Sign the CLA
  https://cla.developers.google.com/about/google-individual?csw=1

• Write a good commit message

• Push to your fork

• Create pull request

• Check solution passes on Travis

Commit Messages

fix(ngOptions): do not watch properties starting with $

Expressions that compute labels and track by values for ngOptions were being called for properties, that start with $ even though those properties were being ignored as options.

Closes #11930

Create a Pull Request

• Push to your fork

  git push -u origin/issue-11930
  

• Create a Pull Request
  https://github.com/angular/angular.js
• Check Travis Build
  https://travis-ci.org/angular/angular.js