Gerrit Code Review

by Noah Hartmann

Short Answer:

"Code Review based Git-System"
- requires a Code Review before merging the pushed code

What is Gerrit?

About the Code-Review System

Gerrit allows to review commits before they are integrated into a target branch
Code Review is optional
- But required by default
- Possible to grant special access rights for direct push

Importance of reviewing code
- best way to integrate it into your daily work life
How Gerrit can help you with that...
How to set up & how to use Gerrit

1. Make a change

changed code

commit & push

specific repository

2. Set up the review

3. Others review your code

4. Rework your code according to the reviews

5. Verify the change

-1

Senior Dev

6. Submit

Submit Type: Merge

Submit Type: Rebase

Note: Those submit types only take effect if there is a new untreated commit

To detect defects and fix them immediately. For Example:

Compilation Errors
Duplicate code (e.g. Methods which already exist)
Insufficient error condition handling
- enhance error handling to make it more robust
Too few tests
- more tests to prevent a bug from regressing
Outdated tests
- adapt tests to reflect changed behavior
Messy Code
Insufficient commit message

History:

As Version Control System for the development of Android
Based on similar Framework of Google named "Mondrian"
First Name was "Rietveld", but later forked to Gerrit
- Name comes from popular Architect "Gerrit Rietveld"