Goldilocks and the Three Code Reviews
@vaidehijoshi
π» π» π»
ππ½
π©π½βπ»
Β π
π
π
π€
π
πͺ
π
π©π½βπ»
Β π
π
π
π
π©π½βπ»
Β π
π
π
π
π
π
π
π
π
π
π
π
π
LGTM
LGTM
LGTM
LGTM
LGTM
π¨
π₯
π¨
π₯
π₯
π¨
π¨
π¨
π©π½βπ
π
oh no.
we really got this code review thing down!
lol j/k NOPE
we really got this code review thing down!
π€¦π½ββοΈ
Β π
There must be a better way of doing code reviews!
...Right?
Code Complete
catching problems at the βlowest-valueβ stage
π©π½βπ»
Β π
βquality gatesβ
π€
π
π©π½βπ»
π
π₯
Β π
collective ownership in construction
inspections
π©π½βπ»
Β π
defect-detection
not correction
short reviews
π©π½βπ»
Β π
![](https://s3.amazonaws.com/media-p.slid.es/uploads/342540/images/3730568/new_doc_2017-04-23_10.31.40_1.jpg)
Code Complete, 2nd Edition,
Steve McConnell
walk throughs
π©π½βπ»
Β π
working meetings
![](https://s3.amazonaws.com/media-p.slid.es/uploads/342540/images/3730410/Screen_Shot_2017-04-23_at_8.56.31_AM.png)
Peer Reviews in Software: A Practical Guide,
Karl E. Wiegers
![](https://s3.amazonaws.com/media-p.slid.es/uploads/342540/images/3731507/Screen_Shot_2017-04-23_at_5.07.07_PM.png)
![](https://s3.amazonaws.com/media-p.slid.es/uploads/342540/images/3730409/Screen_Shot_2017-04-23_at_9.37.45_AM.png)
![](https://s3.amazonaws.com/media-p.slid.es/uploads/342540/images/3731529/Screen_Shot_2017-04-23_at_5.34.07_PM.png)
![](https://s3.amazonaws.com/media-p.slid.es/uploads/342540/images/3730404/benefits_by_language.jpg)
![](https://s3.amazonaws.com/media-p.slid.es/uploads/342540/images/3730402/pull_review_overall.jpg)
![](https://s3.amazonaws.com/media-p.slid.es/uploads/342540/images/3730401/pull_review_by_language.jpg)
![](https://s3.amazonaws.com/media-p.slid.es/uploads/342540/images/3730830/Screen_Shot_2017-04-23_at_11.21.19_AM.png)
![](https://s3.amazonaws.com/media-p.slid.es/uploads/342540/images/3730832/Screen_Shot_2017-04-23_at_11.22.17_AM.png)
![](https://s3.amazonaws.com/media-p.slid.es/uploads/342540/images/3730836/Screen_Shot_2017-04-23_at_11.21.34_AM.png)
Who is doing the review?
Energy
How much time are they spending on it?
big commits, large PR's, no context
unequal reviewsΒ
second-class citizens
π
π
π
What exactly are they saying or doing while reviewing?
Substance
And how?
tons of comments, little conversation
focusing on style/ syntax
ego over empathy
π
π
π
π©π½βπ»
π€·π½ββοΈ
![](https://s3.amazonaws.com/media-p.slid.es/uploads/342540/images/3730895/skylight-logo.png)
ππ½
![](https://s3.amazonaws.com/media-p.slid.es/uploads/342540/images/4267192/Ember-logo.png)
1. Β commit hooks
small wins
![](https://s3.amazonaws.com/media-p.slid.es/uploads/342540/images/4267267/Screen_Shot_2017-10-26_at_4.10.53_PM.png)
1. Β commit hooks
2. PR templates
small wins
![](https://s3.amazonaws.com/media-p.slid.es/uploads/342540/images/4267226/Screen_Shot_2017-10-26_at_4.04.26_PM.png)
1. Β commit hooks
2. PR templates
3. screenshots/gifs
small wins
![](https://s3.amazonaws.com/media-p.slid.es/uploads/342540/images/4267294/giphy-downsized__1_.gif)
1. Β commit hooks
2. PR templates
3. screenshots/gifs
4. linters
small wins
![](https://s3.amazonaws.com/media-p.slid.es/uploads/342540/images/4267319/giphy-downsized-large.gif)
1. Β commit hooks
2. PR templates
3. screenshots/gifs
5. encapsulation
4. linters
small wins
![](https://s3.amazonaws.com/media-p.slid.es/uploads/342540/images/4267339/giphy__5_.gif)
1. Β commit hooks
2. PR templates
3. screenshots/gifs
5. encapsulation
4. linters
6. specific reviewers
small wins
![](https://s3.amazonaws.com/media-p.slid.es/uploads/342540/images/4267342/Screen_Shot_2017-10-26_at_4.21.17_PM.png)
![](https://s3.amazonaws.com/media-p.slid.es/uploads/342540/images/4267343/Screen_Shot_2017-10-26_at_4.21.26_PM.png)
1. Β review everyone: push for a culture that values vulnerability
2. develop empathy: call out the good stuff, too!
big wins
itπerπateπ
3.Β
iterate
iterate
start the conversation
π€
I love code reviews in theory.
In practice, they are only as good as the group thatβs responsible for conducting them in the right manner.
bettercode.reviews
β¨
thank you!
@vaidehijoshi
http://bit.ly/better-code-reviews
Better Code Reviews
By Vaidehi Joshi
Better Code Reviews
- 4,145